fix(maven): Snapshot gradle props instead of deleting - #278
Closed
iker-barriocanal wants to merge 18 commits into
Closed
fix(maven): Snapshot gradle props instead of deleting#278iker-barriocanal wants to merge 18 commits into
iker-barriocanal wants to merge 18 commits into
Conversation
BYK
requested changes
Aug 24, 2021
BYK
requested changes
Aug 26, 2021
BYK
left a comment
Member
There was a problem hiding this comment.
Pushing back for the following reasons:
fs.acccesscheck- Converting this into a wrapper function like
withTempDir() - Converting the tests into "real world" tests instead of implementation checks:
Actually have a file on the file system and instead of mocking these functions, make sure we get back the original states: non-existent gradle file, gradle file with user info. It should also ensure the proper file is created during the process.
BYK
reviewed
Sep 6, 2021
BYK
left a comment
Member
There was a problem hiding this comment.
Context manager looks great and see how much it simplifies the code!
BYK
requested changes
Sep 10, 2021
Comment on lines
+399
to
+400
| await expect(fsPromises.access(expectedPropsPath)).rejects.toThrowError( | ||
| /ENOENT: no such file/ |
Member
There was a problem hiding this comment.
Why not just expect(fs.exists(expectedPropsPath)).to.not.be.true()?
Contributor
Author
There was a problem hiding this comment.
Because to and be don't exist. Moving to accessSync since it's cleaner, but if you know an even cleaner way I can update it.
| async () => await testCorrectPropsFile(expectedPropsPath) | ||
| ); | ||
|
|
||
| await mvnTarget.publish('v3rs10n', 'r3v1s10n'); |
Member
There was a problem hiding this comment.
I expected you to test withGradleProps directly here, instead of mocking upload with your test method and then invoking publish. This would be the correct way to write a unit test for your helper.
| }); | ||
| }); | ||
|
|
||
| test('existent props file', async () => { |
Member
There was a problem hiding this comment.
You are missing some test cases:
- What if the callback function throws an error? You should test that we still restore the snapshot/delete our own props file
- What if we simply cannot backup an existing snapshot file? Where's the test case for that?
- What if we cannot restore a snapshot file for some reason?
It's accepted use case to not exist the file. It's not an accepted use case to exist and to not be able to read the file.
Contributor
|
Superseded by #351 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #276 the gradle properties file was removed, causing the loss of any user config that may exist in that file. This PR makes a snapshot of the file at the beginning of the
maventarget execution and restores it at the end, so the user config shouldn't be affected.