feat(changelog): Auto generate changelog when empty - #287
Merged
Conversation
iker-barriocanal
left a comment
Contributor
There was a problem hiding this comment.
Should we add tests for the PR ID format in the commit messages?
Member
Author
Thought about that but I think a better test would be to test the new changelog generation logic: make sure we have a PR id at the end, if not fallback to short SHA etc. For that I need to construct a sample/fake repo in tests. That said since this feature is ephemeral and will evolve very quickly to use GitHub milestones, I think delaying tests for that next step makes more sense. |
BYK
added a commit
that referenced
this pull request
Sep 17, 2021
* ref: Add comments for changelog extraction Follow up to #287 Co-authored-by: Chad Whitacre <chadwhitacre@sentry.io>
BYK
added a commit
that referenced
this pull request
Sep 20, 2021
This patch implements the GitHub Milestones based automatic changelog generation. It builds up on #285 and #287 and ties them with GitHub milestone data to generate a changelog that is composed of logical sections with references to relevant PRs. Any remaining items are put under "Various fixes & improvements" section as an itemized list.
BYK
added a commit
that referenced
this pull request
Sep 23, 2021
This patch implements the GitHub Milestones based automatic changelog generation. It builds up on #285 and #287 and ties them with GitHub milestone data to generate a changelog that is composed of logical sections with references to relevant PRs. Any remaining items are put under "Various fixes & improvements" section as an itemized list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.