ref: Fix TypeScript type warning regarding catch - #288
Merged
Conversation
iker-barriocanal
left a comment
Contributor
There was a problem hiding this comment.
Don't we need to set either --strict or --useUnknownInCatchVariables? See https://www.typescriptlang.org/tsconfig#useUnknownInCatchVariables
BYK
enabled auto-merge (squash)
September 15, 2021 13:09
iker-barriocanal
approved these changes
Sep 15, 2021
Member
Author
Seems like this became the default since TS 4.4. Not sure what I'm getting but this doesn't break anything and also makes our code future-proof so I'd just land 馃榾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript now defaults to
unknownfor caught error types instead ofanycausing us to get warnings when trying to access some standardErrorproperties. This PR changes the code accordingly so it is both safer, cleaner, and does not have this warning anymore.