Skip to content

upgrade(octokit): Upgrade octokit to v18 - #290

Merged
BYK merged 4 commits into
masterfrom
byk/upgrade/octokit
Sep 20, 2021
Merged

upgrade(octokit): Upgrade octokit to v18#290
BYK merged 4 commits into
masterfrom
byk/upgrade/octokit

Conversation

@BYK

@BYK BYK commented Sep 17, 2021

Copy link
Copy Markdown
Member

This is needed so we can use the GraphQL endpoints.

List of breaking changes: https://github.com/octokit/rest.js/releases/tag/v18.0.0

All tests pass and also manually verified locally by preparing and releasing https://github.com/getsentry/release-tester/releases/0.18.0

This is needed so we can use the GraphQL endpoints.
@BYK
BYK marked this pull request as ready for review September 18, 2021 17:24

@iker-barriocanal iker-barriocanal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to have types for GitHub endpoint methods!

Comment thread src/artifact_providers/github.ts
@BYK
BYK merged commit c978bf6 into master Sep 20, 2021
@BYK
BYK deleted the byk/upgrade/octokit branch September 20, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants