fix(changelog): Make auto changelog titles level 3 - #295
Merged
Conversation
In #291 we used level 2 headers for subsections in the auto generated changelogs. This made them collide with the level 2 version headers, causing our GitHub target to not pick up the automatically generated changelog. It is also semantically incorrect. This patch fixes the issue, introduces constants to determine these levels, and adds a helper function that utilizes these constants.
iker-barriocanal
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #291 we used level 2 headers for subsections in the auto
generated changelogs. This made them collide with the level 2
version headers, causing our GitHub target to not pick up the
automatically generated changelog. It is also semantically
incorrect.
This patch fixes the issue, introduces constants to determine
these levels, and adds a helper function that utilizes these
constants.