fix: github release uploads - #302
Merged
Merged
Conversation
The upload requires binary data not strings. Unfortunately the typing information in the generated octokit typings is wrong about this. Passing a string here creates invalid binary uploads and has caused an incident at Sentry that caused invalid uploads. Octokit issue: octokit/octokit.js#2086 Fixes getsentry/sentry-cli#1037
Swatinem
approved these changes
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload requires binary data not strings. Unfortunately the typing
information in the generated octokit typings is wrong about this.
Passing a string here creates invalid binary uploads and has caused an
incident at Sentry that caused invalid uploads.
Octokit issue: octokit/octokit.js#2086
Fixes getsentry/sentry-cli#1037