feat(github): Verify release uploads for GitHub - #308
Merged
Conversation
We had an incident where we sent UTF-encoded string when uploading GitHub release artifacts after an Octokit upgrade due to misleading types. We haven't noticed the issue until it was too late as we lack basic checks such as file size and checksums. This patch introduces both checks to the GitHub target. Closes #303.
Member
Author
|
Manually verified with https://github.com/getsentry/release-tester/releases/0.23.0 |
chadwhitacre
reviewed
Oct 5, 2021
Co-authored-by: Chad Whitacre <chadwhitacre@sentry.io>
chadwhitacre
approved these changes
Oct 5, 2021
chadwhitacre
reviewed
Oct 5, 2021
| // And don't even think about using `browser_download_url` | ||
| // field as it is close to impossible to authendicate for | ||
| // that URL with a token and you'll lose hours getting 404s | ||
| // for private repos. Consider yourself warned. --xoxo BYK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an incident where we sent UTF-encoded string
when uploading GitHub release artifacts after an
Octokit upgrade due to misleading types. We haven't
noticed the issue until it was too late as we lack
basic checks such as file size and checksums. This
patch introduces both checks to the GitHub target.
Closes #303.