chore(nuget): clarify publish behavior reentrant - #619
Merged
Conversation
bruno-garcia
commented
Oct 1, 2025
BYK
requested changes
Oct 2, 2025
BYK
left a comment
Member
There was a problem hiding this comment.
Thanks so much for the very quick turn around.
Can we also add a comment to the code where we added this behavior as people working on Craft tend not to read the huge readme 馃槄
Co-authored-by: Burak Yigit Kaya <ben@byk.im>
Member
Author
The diff was only the |
bruno-garcia
enabled auto-merge (squash)
October 3, 2025 22:51
BYK
approved these changes
Oct 6, 2025
BYK
left a comment
Member
There was a problem hiding this comment.
Added the comment myself for future reference as I have no idea what --skip-duplicate would do and wouldn't expect anyone to intuitively understand that if they don't know about NuGet already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See:
#skip-changelog