This repository was archived by the owner on Aug 14, 2024. It is now read-only.
Protocols new properties described - #358
Merged
bruno-garcia merged 3 commits intoJun 25, 2021
Merged
Conversation
|
@semuserable is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
semuserable
marked this pull request as ready for review
June 24, 2021 15:37
Contributor
Author
|
Please, review and run authorized deploy for Vercel. Can't add reviewers, btw.. |
bruno-garcia
requested review from
bitsandfoxes,
jan-auer and
untitaker
and removed request for
untitaker
June 25, 2021 19:40
untitaker
approved these changes
Jun 25, 2021
untitaker
left a comment
Member
There was a problem hiding this comment.
I'd ask you to add them to https://github.com/getsentry/relay/blob/master/relay-general/src/protocol/contexts.rs as well.
untitaker
reviewed
Jun 25, 2021
Member
Keen to write some Rust? Probably don't even need to compile it locally :D |
bruno-garcia
approved these changes
Jun 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.