build: Replace microbundle with tsc - #180
Conversation
fixes the only blocker to try out rspack. Only commonjs output which is what we had before. The rspack error I think was caused by the bundling of microbundle. ```console Cannot find module '../svg/python.svg' ```
| outputs: | ||
| dependency_cache_key: ${{ steps.compute_lockfile_hash.outputs.hash }} | ||
|
|
||
| job_build: |
There was a problem hiding this comment.
why we don't need this anymore?
There was a problem hiding this comment.
all this step does is run yarn build which isn't worth caching since it only takes a second and the dependency cache is now managed by actions/setup-node@v4
There was a problem hiding this comment.
this action could be simplified even further. before it had 3 steps install + cache, build + cache, run codeql. Really we could just do install, build, codeql as a single step.
| "noImplicitThis": true, | ||
| "noImplicitAny": true, | ||
| "strictNullChecks": true, | ||
| "suppressImplicitAnyIndexErrors": true, |
There was a problem hiding this comment.
It's good that we're removing it. But is it required for the new changes to work?
There was a problem hiding this comment.
suppressImplicitAnyIndexErrors is no longer supported by typescript and i've updated to the latest version
fixes the only blocker to try out rspack. Only commonjs output which is what we had before.
The rspack error I think was caused by the bundling of microbundle.
Cannot find module '../svg/python.svg'checkout rspack branch here getsentry/sentry#77077