fix(rrweb): Guard cross-origin Element read in ShadowDomManager.obs… - #322
Merged
Conversation
…erveAttachShadow
s1gr1d
commented
Sep 2, 2026
chargome
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #321
For a cross-origin iframe,
contentWindowdoes not throw — the browser returns a truthy restricted proxy. So the!iframeWindowguard inobserveAttachShadowpasses, and the bareiframeWindow.Elementread is the first real cross-origin access. It throws aSecurityError, or yieldsundefinedandpatchAttachShadowthen throws aTypeErroronelement.prototype. Both escape into the host page'swindow.onerror.Fixed by reading
Elementinside try/catch and bailing out when it isunreachable, since replay cannot observe a frame the browser blocks.