Java: Add BOM docs. - #3832
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/CCjxxms1pHFDJhE56xjN3eB1LGy6 |
|
|
||
| <PlatformContent includePath="getting-started-install" /> | ||
|
|
||
| <PlatformContent includePath="getting-started-install-bom" supported={["java"]} /> |
There was a problem hiding this comment.
Perhaps there is a better way to include this piece into every Java guide?
|
I am not 100% convinced that this is the right place to put BOM docs. AFAIR we aimed "Getting Started" for having only essential information - BOM docs are useful only if more than one Sentry dependency is used (Android + Coroutines, Spring + Logback etc). |
based on my comment here #3652 (comment) if the install steps don't include 2 dependencies or more, we don't add the bom, but rather to the integrations or guides that do, eg https://github.com/getsentry/sentry-docs/blob/master/src/platforms/android/configuration/integrations/fragment.mdx |
that makes sense, not sure how the |
|
@marandaneto updated. |
bruno-garcia
left a comment
There was a problem hiding this comment.
I think this is something @PeloWriter and @marandaneto might have thoughts but if they are happy with it, it also LGTM
One question/suggestion about Android.
Another detail is to possibly not have it as a top level item. Maybe add under configuration?
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
|
@PeloWriter @marandaneto @bruno-garcia please take another look. |
|
@maciejwalkowiak seems we didn't ship I jumped the gun here by merging this, should I revert? |
|
@bruno-garcia I believe it should be reverted, and merged only once BOM PR is merged and 5.1.0 is released. |
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
This reverts commit 21bf9c3.
|
Raised #3939 |
|
Draft to add this back once 5.1.0 is out: #3940 |

Closes #3652