Conversation
giortzisg
force-pushed
the
scopes/http-integration
branch
from
August 31, 2026 10:50
dcb9bbb to
b7e8a83
Compare
giortzisg
marked this pull request as ready for review
August 31, 2026 10:51
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 1, 2026 09:13
b7e8a83 to
aa34125
Compare
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 1, 2026 12:57
aa34125 to
0c7f2a6
Compare
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 2, 2026 07:59
0c7f2a6 to
a5c324b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a5c324b. Configure here.
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 4, 2026 13:12
a5c324b to
fc11ac3
Compare
giortzisg
changed the base branch from
scopes/capture-panic
to
scopes/logging-integrations-context
September 4, 2026 13:12
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 4, 2026 13:26
fc11ac3 to
20d058f
Compare
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 7, 2026 11:40
20d058f to
766cdf6
Compare
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 7, 2026 11:49
766cdf6 to
84d0b5c
Compare
szokeasaurusrex
approved these changes
Sep 9, 2026
Comment on lines
-126
to
+122
| hub.Scope().SetRequest(r) | ||
| r = r.WithContext(transaction.Context()) | ||
| defer h.recoverWithSentry(hub, r) | ||
| scope.SetRequest(r) |
Member
There was a problem hiding this comment.
[question] does the reordering of the WithContext and SetRequest lines change behavior at all, and if so, how?
| ctx, scope := sentry.WithIsolationScope(r.Context()) | ||
|
|
||
| if client := hub.Client(); client.IsEnabled() { | ||
| if client := sentry.ClientFromContext(ctx); client.IsEnabled() { |
Member
There was a problem hiding this comment.
[question] I am struggling to find where the client ever gets set on the http.Request context.
Does this happen automatically somehow?
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 16, 2026 09:14
84d0b5c to
29129a3
Compare
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 17, 2026 08:38
29129a3 to
cfca6cc
Compare
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 17, 2026 09:09
cfca6cc to
664e178
Compare
Create an isolated context scope for each request and route capture and flushing through the contextual client. Continue incoming traces from all baggage header values. When middleware reuses an active transaction, preserve the caller context and child span. Only middleware that creates the transaction updates its metadata and finishes it, so nested instrumentation cannot close an outer request early.
giortzisg
removed this pull request from stack #1420
September 18, 2026 11:17
giortzisg
force-pushed
the
scopes/http-integration
branch
from
September 18, 2026 11:18
664e178 to
49144c4
Compare
giortzisg
added this pull request to stack #1433
September 18, 2026 11:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This migrates the http integration to scopes.
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)