Skip to content

ref(transport): move HTTP delivery into the root package - #1425

Open
giortzisg wants to merge 1 commit into
ref/legacy-transport-movefrom
ref/http-transport-move
Open

giortzisg wants to merge 1 commit into
ref/legacy-transport-movefrom
ref/http-transport-move

Conversation

@giortzisg

Copy link
Copy Markdown
Contributor

Description

Issues

Changelog Entry Instructions

To add a custom changelog entry, uncomment the section above. Supports:

  • Single entry: just write text
  • Multiple entries: use bullet points
  • Nested bullets: indent 4+ spaces

For more details: custom changelog entries

Reminders

Stack created with GitHub Stacks CLIGive Feedback 💬

Move the implementation and tests to their final paths without changing delivery behavior.
@giortzisg
giortzisg added this pull request to stack #1428 September 10, 2026 10:42

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2e16e63. Configure here.

Comment thread transport.go
defaultClientReportsTick = time.Second * 30
defaultHTTPTimeout = time.Second * 30
defaultHTTPQueueSize = 1000
defaultHTTPClientReportsTick = time.Second * 30

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal transport API leaked publicly

Medium Severity

TransportOptions, ErrTransportQueueFull, ErrTransportClosed, and ErrEmptyEnvelope were exported so the root package could use them from internal/http. After the move they remain exported on the public sentry API, even though the constructors and transport types were unexported. Callers have no public way to construct these transports or receive these errors, so the exports become a permanent surface that cannot later be removed without a breaking change.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2e16e63. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant