feat(google-cloud-serverless): Emit low cardinality function.gcp span names - #24060
Merged
Conversation
Lms24
force-pushed
the
lms/feat-gcp-faas-span-names
branch
from
September 4, 2026 08:56
0ea6adc to
ae80636
Compare
| // not yet in conventions but this attribute will also determine the span description | ||
| [GCP_FUNCTION_CONTEXT_EVENT_TYPE]: context.eventType, | ||
| [GCP_FUNCTION_CONTEXT_EVENT_ID]: context.eventId, | ||
| [GCP_FUNCTION_CONTEXT_RESOURCE]: context.resource, |
There was a problem hiding this comment.
Object resource set as span attribute
Medium Severity
gcp.function.context.resource is written from context.resource with no type check. Legacy GCP event contexts often supply resource as an object (service, name, type), including Pub/Sub. setAttribute stores that object, so spans can carry a non-primitive attribute. The existing gcpContextIntegration already skips non-string resource values for this reason.
Reviewed by Cursor Bugbot for commit ae80636. Configure here.
Contributor
size-limit report 📦
|
Lms24
marked this pull request as ready for review
September 4, 2026 09:41
Lms24
force-pushed
the
lms/feat-gcp-faas-span-names
branch
from
September 4, 2026 11:11
ae80636 to
a568b71
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a568b71. Configure here.
Lms24
force-pushed
the
lms/feat-gcp-faas-span-names
branch
from
September 4, 2026 12:11
a568b71 to
f6bba3d
Compare
nicohrubec
approved these changes
Sep 8, 2026
nicohrubec
left a comment
Member
There was a problem hiding this comment.
just some minor comments, lgtm!
Lms24
force-pushed
the
lms/feat-gcp-faas-span-names
branch
from
September 8, 2026 14:23
f6bba3d to
43dfada
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts
function.gcpspans:function.gcpspan description rules sentry-conventions#624 adds new needed description rules to conventions.gcp.function.contextattributes which were previously only set on the transaction event contextref #23954