test(e2e): Port Ember E2E apps to span streaming - #24168
Merged
Merged
Conversation
ember-classic, ember-embroider, and ember-vite drop the static lifecycle pin. Router children are named Router under streaming; pageload and navigation segments keep the parameterized route name. ember-classic-static is skipped because ember-strict-resolver already runs both lifecycles. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Contributor
size-limit report 📦
|
RulaKhaled
marked this pull request as ready for review
September 8, 2026 12:15
Lms24
approved these changes
Sep 10, 2026
Comment on lines
+14
to
+20
| name: 'route:index', | ||
| is_segment: true, | ||
| attributes: { | ||
| 'sentry.op': { type: 'string', value: 'pageload' }, | ||
| 'sentry.origin': { type: 'string', value: 'auto.pageload.ember' }, | ||
| 'sentry.segment.name.source': { type: 'string', value: 'route' }, | ||
| 'url.template': { type: 'string', value: '/' }, |
Member
There was a problem hiding this comment.
Not part of this PR but this surfaces a bug in the Ember SDK: The name must be reflected either in url.template or (probably better for this case) router.navigation.route.id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
traceLifecycle: 'static'pin fromember-classic,ember-embroider, andember-vite, and rewrites their specs onto streamed spans.Why
Ember
routerchild spans becomeRouterunder streaming, so those assertions cannot stay asroute:a -> route:b. Classic and embroider keep the fuller URL and child-span coverage; vite is thinner in the original suite and stays that way.ember-classic-staticis skipped.ember-strict-resolveralready runs the full static transaction suite in default CI and already has a streamed variant from #23548, so a third Ember copy would only duplicate that.Part of #23805