Conversation
isaacs
requested review from
JPeer264 and
mydea
and removed request for
a team
September 11, 2026 17:36
Member
Author
|
Added a second commit to bound the number of spans that can potentially be hanging. It's a preexisting hazard that all 4 implementations had, but noticed in the refactor. If others feel like it'd be better to put off, that can be a separate issue for discussion (or ditched entirely if it's not a relevant concern), but it seemed convenient to just fix it while in the area. |
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacschlueter/js-3667-consolidate-the-global-fetch-integrations-into-sentryserver
branch
from
September 14, 2026 03:50
1793a3c to
19bd663
Compare
JPeer264
reviewed
Sep 14, 2026
JPeer264
left a comment
Member
There was a problem hiding this comment.
It seems the react-send-to-sentry test has one record less now (not sure from just looking at the test if it is related, but it failed consistently in the CI):
- "length": 12,
+ "length": 11,
isaacs
force-pushed
the
isaacschlueter/js-3667-consolidate-the-global-fetch-integrations-into-sentryserver
branch
from
September 14, 2026 19:55
19bd663 to
5be3ad5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5be3ad5. Configure here.
Member
Author
|
@JPeer264 The react-send-to-sentry replay test is failing in the exact same way on develop, and is known flaky optional, so I think it's safe to say it's unrelated to this change. |
isaacs
force-pushed
the
isaacschlueter/js-3667-consolidate-the-global-fetch-integrations-into-sentryserver
branch
2 times, most recently
from
September 15, 2026 21:40
6ae587b to
38e5c4b
Compare
isaacs
added this pull request to stack #24407
September 15, 2026 21:41
JPeer264
approved these changes
Sep 16, 2026
Consolidate the nearly (but not exactly!) identical fetch integrations used by deno, bun, cloudflare, and vercel-edge. The functionality is placed in `@sentry/core` rather than `@sentry/server-utils` in order to avoid leaking node internals where they don't belong. closes JS-3667 closes #24344
mydea
force-pushed
the
isaacschlueter/js-3667-consolidate-the-global-fetch-integrations-into-sentryserver
branch
from
September 16, 2026 08:27
38e5c4b to
32d338d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the nearly (but not exactly!) identical fetch integrations used by deno, bun, cloudflare, and vercel-edge.
The deno
breadcrumbsintegration is folded in, and the separate integration is deprecated.The functionality is placed in
@sentry/corerather than@sentry/server-utilsin order to avoid leaking node internals where they don't belong.Node and Browser fetch integrations are not touched, because they use completely different mechanisms.
closes JS-3667
closes #24344