fix(google-genai): Map messages to the gen_ai conventions - #24352
Merged
Merged
Conversation
Google's `Content` was reported verbatim, so `gen_ai.input.messages` carried
`{role, parts: [{text}]}` instead of `{role, parts: [{type, content}]}`. The
product's normalizer drops parts it cannot type, so none of the input messages
rendered, and `role: "model"` is not a `gen_ai` role.
Every part kind is now translated (text, thought, function call, function
response, inline data, file data), `model` becomes `assistant`, and bare parts
in one array stay one turn so a multimodal message is not split.
A `config.systemInstruction` passed as a `Content` object also never reached
`gen_ai.system_instructions`: it was routed through `extractSystemInstructions`,
which only reads `.content`. It is now read straight off the config.
Also sets `gen_ai.output.messages`, which this integration never wrote. Relay's
migration of the deprecated `gen_ai.response.text` is lossy for tool calls, so a
turn that only called a tool rendered an empty Output.
Fixes #24327
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
logaretm
marked this pull request as ready for review
September 12, 2026 00:40
logaretm
requested review from
JPeer264 and
mydea
and removed request for
a team
September 12, 2026 00:40
JPeer264
approved these changes
Sep 14, 2026
JPeer264
left a comment
Member
There was a problem hiding this comment.
implementation looks fine IMO. Would wait for @RulaKhaled for a better judgement though
RulaKhaled
approved these changes
Sep 14, 2026
RulaKhaled
left a comment
Collaborator
There was a problem hiding this comment.
lgtm! This used to be a requirement of otel conventions which we no longer follow
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4745a84. Configure here.
| } | ||
|
|
||
| // Part kinds we don't know yet render as JSON rather than disappearing. | ||
| return { type: 'object', content: part }; |
There was a problem hiding this comment.
Thought signatures recorded as object parts
Medium Severity
partToMessagePart never handles thoughtSignature, so a part that only carries that field hits the unknown-part fallback and stores the raw base64 blob on gen_ai.input.messages and gen_ai.output.messages. Thinking models attach these signatures on later turns, which inflates span payloads the same way inlineData.data would.
Reviewed by Cursor Bugbot for commit 4745a84. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google GenAI reported its own
Contentshape, so no input message rendered, fixed by mapping parts and roles to the conventions.I added tests covering each part kind, an object
systemInstruction, and a tool call's output messages.closes #24327