You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the case in which a user either provides an integrations array which includes an instance of onUncaughtException or provides a function which returns such an array, this will work, because it will update that instance with the new option. In all other cases, however, the fact that there won't be an onUncaughtException instance in options.integrations when those options are passed to nodeInit means that the default instance (without the new option set) will end up being included. If we want the integration to exist with the new option, we have to add it at the addOrUpdateIntegration stage.
I think we can do this a lot more simply, without having to duplicate most of the code in addOrUpdateIntegration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @lobsterkatie mentioned in #6138 (comment) we should properly address what happens if users modify the
OnUncaughtExceptionintegration.