fix(crashpad): Respect consent for external crash reporters - #1972
Merged
Conversation
Update Crashpad to consult its upload setting before launching an external reporter, leaving disabled reports available for later processing. Cover revoked consent with caching, without caching, and after consent is restored.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1972 +/- ##
=======================================
Coverage 76.17% 76.18%
=======================================
Files 94 94
Lines 22222 22222
Branches 3942 3942
=======================================
+ Hits 16928 16930 +2
+ Misses 4409 4408 -1
+ Partials 885 884 -1 🚀 New features to boost your workflow:
|
JoshuaMoelans
approved these changes
Aug 11, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Crashpad to check user consent (upload setting) before launching an external reporter, leaving disabled reports available for later processing.
Cover revoked consent with caching, without caching, and after consent is restored.
Close: #1936