Silenced error detection not working correctly

[alexander-schranz]

We have basically default installation of sentry in our symfony application, currently the following sentry packages installed

sentry/sdk: 2.1.0
sentry/sentry: 2.4.0 
sentry/sentry-symfony:3.5.1

Sentry is running on its default configuration we just have the dsn configured:

sentry:
      dsn: "%env(SENTRY_DSN)%"

But we still get the following errors the following sentry errors:

Sentry\Exception\FatalErrorException
Compile Warning: Unterminated comment starting line 41
/vendor/phpcr/phpcr-migrations/lib/MigratorUtil.php at line 41

            // Read entire lines to prevent keyword truncation
            for ($line = 0; $line <= 20; $line++) {
                $buffer .= fgets($fp);
            }
            $tokens = @token_get_all($buffer); // this is line 41 which fails

Screenshot

as we don't have capture_silenced_errors activated this error should not appear.

What is strange that it is detected as FatalErrorException and if I look at the current code here, it should be a SilencedErrorException so it is not logged, so maybe there is the error but I'm not sure.

The code throwing this warning is basically very simple: token_get_all("<?php /*");.

[Jean85]

Confirmed, reproduced in #1051.

[ste93cry]

What is strange that it is detected as FatalErrorException and if I look at the current code here, it should be a SilencedErrorException so it is not logged, so maybe there is the error but I'm not sure.

Technically speaking you are absolutely right: the error should be silenced. However, practically, this is a kind of fatal error and PHP does not handle it through the error handler, so the capture_silenced_errors option gets ignored as it's used only by the ErrorListenerIntegration class. Even if we were to use that option in the FatalErrorListenerIntegration class we would not be able to distinguish whether it was suppressed because PHP doesn't allow suppression of fatal errors. I don't really have an idea of how we can fully solve this issue, as ignoring E_CORE_WARNING and E_COMPILE_WARNING errors would then cause those to never be catched, while adjusting the code to log them as errors instead of fatals still won't ignore them if they were suppressed.

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[Jean85]

Closing this, since the reproducer in #1051 is basically the same as this one:

sentry-php/tests/phpt/error_handler_respects_capture_silenced_errors_option.phpt

Lines 56 to 64 in 8fea3e3

	echo 'Triggering silenced error' . PHP_EOL;
	@$a++;
	$client->getOptions()->setCaptureSilencedErrors(false);
	echo 'Triggering silenced error' . PHP_EOL;
	@$b++;

So fixed in #1183