Conversation
Contributor
|
it's possible for sentry to be installed w/ older versions of guzzlehttp/psr7 which have the now-deprecated copy_to_string() instead of Utils::copyToString() https://github.com/guzzle/psr7/blob/1.x/src/functions.php#L194 |
Contributor
Author
|
Thanks for noticing it, I didn't see it because PHPUnit emitted a warning and the build was green! |
Jean85
approved these changes
Nov 23, 2020
ste93cry
deleted the
fix/request-integration-does-not-capture-request-body
branch
November 27, 2020 09:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in #1119 and closes #1135: in particular, the
php://inputstream is not a file andfstatdoes not work on it andStreamInterface::getSize()always return0. In reality, using the PSR-7 implementation from Guzzle that method does work as you read from the stream, but it does just because it remembers how many bytes it read until that point. Other SDKs implementations use theContent-Lengthheader, I decided to do the same even though it may report incorrect data (which is unlikely anyway)