Detect errors if a request body size is zero - #1119
Merged
Merged
Conversation
ste93cry
suggested changes
Oct 25, 2020
ste93cry
left a comment
Contributor
There was a problem hiding this comment.
Build is broken, probably due to an update of PHPStan. Can you please remove the ignored error from the phpstan.neon file and see if it works?
Contributor
|
@Bziks are you willing to make the changes to make this PR mergeable? Otherwise I will take care of them for you |
ste93cry
approved these changes
Nov 5, 2020
ste93cry
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your initial work, since I want to release the next patch version asap I took the time to fix the remaining issues. I will also take care of backporting this fix to the 2.x series
ste93cry
added a commit
that referenced
this pull request
Nov 27, 2020
ste93cry
added a commit
that referenced
this pull request
Nov 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue - #1118