Conversation
Merged
ste93cry
suggested changes
Nov 27, 2020
ste93cry
left a comment
Contributor
There was a problem hiding this comment.
Can you please add a CHANGELOG entry?
ste93cry
approved these changes
Nov 27, 2020
ste93cry
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your help, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to execute the unit tests of the latest state of the
php8-supportbranch locally, I was able to find the reason why theerror_handler_respects_error_reporting.phpttest keeps failing. The reason is mentioned in the official php 8 migration guide:You will see that the error_reporting under php 8 no longer returns 0 (none) within a custom error handler: https://3v4l.org/qZ1OG
After this change, my local tests run successful under php 7.2 - 8.0. This does not fix the Segmentation faults or the other remaining CI issues.