PHP 8 Support - #1087
PHP 8 Support#1087
Conversation
|
Closing/reopening to trigger CI restart. |
… after updating PHP minimum required version
|
I think that |
|
Please don't merge the branch on the PR but rebase instead to keep the history cleaner 😉 Also build is failing due to PHPStan |
|
History is not an issue since we do squash+merge; I prefer merges since they create less issues with conflicts. PHPStan issue fixed. |
|
Blocked by vimeo/psalm#4408 (which is already fixed but unreleased) |
|
Also, I can't reproduce current failures locally 😢 |
|
The PHP-Parser package released a new version v4.10.3 including nikic/PHP-Parser#736, but unfortunately Travis CI still keeps failing. The main reason is the "Segmentation fault" error. At this point, I think this is a problem in the Travis environment. When running the same tests locally or via GitHub actions, this error does not occur. I don't know if you want to stick with Travis here, but if not, feel free to use the GitHub actions I created in my fork. However, apart from the CI stuff, there is still one issue pending: |
|
Travis got its PHP 8 images! I'll try one more run... |
|
I'm a bit surprised that the memory test was so easy to fix, but it makes a lot of sense that newer phpunit versions just use more memory when running with code coverage. I didn't think of that 😄 Nice work @ste93cry! If you now change the php 8 Travis image to |
910e926 to
7a8134c
Compare
stayallive
left a comment
There was a problem hiding this comment.
Thank you for the work on this, excellent 💪
This is temporarily blocked by Jean85/pretty-package-versions#25 (which in turn is blocked by phpspec/prophecy#491)