Remove the FlushableClientInterface and the ClosableTransportInterface interfaces - #1079
Merged
ste93cry merged 2 commits intoSep 2, 2020
Merged
Conversation
Jean85
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FlushableClientInterfaceand theClosableTransportInterfaceinterfaces were added at some point because it was not possible to add the newly created methods needed to support flushing of a client to the existing interface without breaking BC. With this cleanup I'm removing them and I've moved the methods to their respective main interfaces. One more reason for this change is that the methods are part of the Unified API specs and are not treated as something optional that can be added freely on each SDK