Skip to content

Fix broken build of 2.x branch - #1152

Merged
ste93cry merged 1 commit into
getsentry:2.xfrom
ste93cry:fix/update-dependencies-to-fix-travis-ci-build
Dec 11, 2020
Merged

Fix broken build of 2.x branch#1152
ste93cry merged 1 commit into
getsentry:2.xfrom
ste93cry:fix/update-dependencies-to-fix-travis-ci-build

Conversation

@ste93cry

@ste93cry ste93cry commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

While trying to release a new patch version for the 2.5 version I found out that the Travis CI build is broken. With these changes backported from the master branch it should again work.

@ste93cry ste93cry added this to the 2.5 milestone Dec 6, 2020
@ste93cry
ste93cry requested review from Jean85 and stayallive December 6, 2020 00:16
stayallive
stayallive approved these changes Dec 6, 2020
View reviewed changes

@stayallive stayallive left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Jean85

Jean85 commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

The build is still failing though... maybe backporting #1150 could be a better choice?

@ste93cry

ste93cry commented Dec 7, 2020

Copy link
Copy Markdown
Contributor Author

Yes, that's my plan. To make Travis work now that Xdebug 3 is on almost all PHP versions it means that we have to do a lot of changes to support both PHPunit 7.5 and 8.5, and probably it isn't worth the time due to the status of the 2.x branch, so let's switch once for all to GitHub Actions and then I will make the required changes here to make the CI pass

@Jean85 Jean85 mentioned this pull request Dec 9, 2020
Merged
@Jean85

Jean85 commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Closing in favor of #1154

@Jean85 Jean85 closed this Dec 9, 2020
@ste93cry

ste93cry commented Dec 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Reopening, this PR has some changes that:

  • fix a bug where the wrong class was reported in the deprecation message
  • fix all the tests that were using the @expectedDeprecation annotation and that weren't working at all

@ste93cry ste93cry reopened this Dec 9, 2020
@ste93cry
ste93cry merged commit d78302c into getsentry:2.x Dec 11, 2020
@ste93cry
ste93cry deleted the fix/update-dependencies-to-fix-travis-ci-build branch December 11, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stayallive stayallive stayallive approved these changes
+1 more reviewer
@Jean85 Jean85 Jean85 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Improvement

Projects

None yet

Milestone

2.5

Development

Successfully merging this pull request may close these issues.

3 participants

@ste93cry @Jean85 @stayallive