Conversation
…d HubAdapter::startTransaction()
Jean85
approved these changes
Jan 21, 2021
Jean85
left a comment
Contributor
There was a problem hiding this comment.
Good job with adding the test too!
ste93cry
deleted the
fix/add-custom-sampling-context-argument-to-start-transaction-method
branch
January 21, 2021 20:48
|
Thanks for the fast fix on this @ste93cry. Would it be too much if I asked for a tagged release of this? Would help me a lot. Thanks 🙏 |
Contributor
Author
|
There is at least another bugfix that I want to merge before releasing the next patch version. I will try to see if I can merge it during the weekend and prepare the release for the first days of the next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title: this should fix the deprecation warnings thrown by Symfony's DebugClassLoader and reported in getsentry/sentry-symfony#419