You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR change the repository structure to use monorepo setup.
The new structure:
/ -> monorepo root private package
/samples -> sampel application, expo, rn...
/packages -> RN SDK packages
/dev-packages -> dev packages, ts-3.8 test runner, e2e tests components and runner
/performance-tests -> applications used for measuring performance in CI
This PR updates the repository to use Yarn V3, as with Yarn V1 the sample applications would not run due to dependencies conflicts. And the original nohoist would not fix the issue. With nmHoistingLimits: workspaces the RN and Expo application are working correctly.
💚 How did you test it?
📝 Checklist
I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes
🔮 Next steps
Test the publish of @sentry/react-native does introduce unexpected (no) changes compared to version 6.0.0-alpha.0
Verify version gets correctly bumped in all dependencies
#skip-changelog
This is a internal change the SDK package published should be unchanged.
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM from monorepo and publishing perspective. Noted down some things to keep in mind when we add more packages but we can do this whenever it's necessary.
Btw: We added this New SDK (package) Checklist to our monorepo docs to keep in mind what to do in which order. Some things are very JS SDK-specific but the general oder of actions and things to keep in mind should apply to this monorepo as well.
The reason will be displayed to describe this comment to others. Learn more.
l (no action required):
Are you keeping the readme of the SDK top level and you copy it to the package to get it into the tarball? No objections btw, just curious.
In the JS SDK monorepo we keep a Readme per package but I guess that's only gonna become necessary if you have more than one package.
The reason will be displayed to describe this comment to others. Learn more.
No immediate action required since you only publish one package at the moment. Once you have more than one pkg, I'd recommend to create one NPM target per package and release in package dependency order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR change the repository structure to use monorepo setup.
The new structure:
This PR updates the repository to use Yarn V3, as with Yarn V1 the sample applications would not run due to dependencies conflicts. And the original
nohoistwould not fix the issue. WithnmHoistingLimits: workspacesthe RN and Expo application are working correctly.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
@sentry/react-nativedoes introduce unexpected (no) changes compared to version6.0.0-alpha.0#skip-changelog
This is a internal change the SDK package published should be unchanged.