fix(tracing): Retry expoRouterIntegration navigationRef lookup#6451
Merged
Conversation
Poll for both `store.navigationRef` and `navigationRef.current` to appear, instead of bailing on the first synchronous check. `Sentry.init()` runs at module eval time (as the docs recommend), which is before Expo Router's Root Layout mounts and populates `store.navigationRef`. Fixes #6431
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
Plus 3 more 🤖 This preview updates automatically when you update the PR. |
Contributor
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6986cf4. Configure here.
…is possible Only attach `reactNavigationIntegration` when `navigationRef.current` is ready to register, so a poll timeout can never leave a non-functional integration on the client. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
lucas-zimerman
approved these changes
Jul 16, 2026
lucas-zimerman
left a comment
Collaborator
There was a problem hiding this comment.
Solid! LGTM one ci test pass
📲 Install BuildsAndroid
|
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f3215d3+dirty | 411.11 ms | 454.38 ms | 43.27 ms |
| d2eadf8+dirty | 414.64 ms | 454.56 ms | 39.92 ms |
| b0d3373+dirty | 557.66 ms | 579.42 ms | 21.76 ms |
| 27d9693+dirty | 419.08 ms | 469.12 ms | 50.04 ms |
| 4e0b819+dirty | 420.56 ms | 470.08 ms | 49.52 ms |
| 9474ead+dirty | 411.45 ms | 446.80 ms | 35.35 ms |
| 0bd8916+dirty | 412.77 ms | 451.31 ms | 38.54 ms |
| f9c1ed4+dirty | 431.00 ms | 466.22 ms | 35.22 ms |
| 3d536d1+dirty | 524.34 ms | 547.32 ms | 22.98 ms |
| 04207c4+dirty | 459.19 ms | 518.54 ms | 59.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f3215d3+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| d2eadf8+dirty | 48.30 MiB | 53.48 MiB | 5.18 MiB |
| b0d3373+dirty | 48.30 MiB | 53.58 MiB | 5.28 MiB |
| 27d9693+dirty | 49.74 MiB | 55.09 MiB | 5.34 MiB |
| 4e0b819+dirty | 49.74 MiB | 54.81 MiB | 5.07 MiB |
| 9474ead+dirty | 48.30 MiB | 53.61 MiB | 5.30 MiB |
| 0bd8916+dirty | 48.30 MiB | 53.57 MiB | 5.26 MiB |
| f9c1ed4+dirty | 49.74 MiB | 54.86 MiB | 5.12 MiB |
| 3d536d1+dirty | 49.74 MiB | 55.26 MiB | 5.52 MiB |
| 04207c4+dirty | 43.75 MiB | 48.12 MiB | 4.37 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
expoRouterIntegrationonly checkedstore.navigationRefonce synchronously inafterAllSetup. If it was still undefined (typical on cold start), the integration warned and bailed — even though the siblingnavigationRef.currentcheck already had polling.Merged both checks into a single polling loop that waits for
store.navigationRefto appear and then for.currentto be populated, within the existing 5s window. Adding the underlyingreactNavigationIntegrationis deferred until the ref is actually seen, so a repo withoutexpo-router(or an incompatible version) still ends up with no integration added — same as before.💡 Motivation and Context
Fixes #6431.
Sentry.init()runs at module eval time (as the docs recommend), which is before Expo Router's Root Layout mounts. That maderegisterNavigationContainer()reliably miss its window on cold start, so no per-navigation transactions were produced for the rest of the session.💚 How did you test it?
picks up navigationRef when it appears mid-poll (issue #6431)— simulates the cold-start ordering (both fields undefined at setup, then appearing) and asserts the container gets registered.expoRouterIntegration.test.tsstill pass (11 total).📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps