Skip to content

Not all URLs are controllable by sidecarUrl #524

Description

@freeatnet

Environment

  • @spotlightjs/spotlight: 2.4.1
  • A Next.js 14.2.7 app running over an ngrok tunnel

Steps to Reproduce

  1. Set up a Next.js app and reverse-proxy it through an ngrok tunnel for mobile development.
  2. Set up Spotlight as documented.
  3. Set up a Sidecar URL as follows:
    1. Update the Spotlight.init({ sidecarUrl: "https://my-tunnel.ngrok.io/_sidecar/stream" }), using a prefix in the path, because /stream is needed for an app route.
    2. In next.config.js, set up a rewrite: { source: "/_spotlight/stream", destination: "http://localhost:8969/stream" }
  4. Launch the app and use the overlay within the page.

Expected Result

All calls needed for the overlay are done through sidecarUrl (like with tunnelRoute in Sentry SDK).

Actual Result

The overlay causes 404s calling https://my-tunnel.ngrok.io/clear (breaking the "clear events" button sync) and https://my-tunnel.ngrok.io/contextlines.

Triage

At least two locations in the code assume that the origin is the only custom part of the sidecarUrl:

  1. packages/overlay/src/integrations/sentry/data/sentryDataCache.ts:49
  2. packages/overlay/src/App.tsx:140

My current workaround is to add /clear and /contextlines to the Next.js rewrites above. It'd be helpful if sidecarUrl acted as the base URL for all sidecar-related endpoints; however, this might require a breaking change in the config semantics.

P.S. Happy to contribute a patch if I can have some guidance on whether it's better to change the semantics of sidecarUrl or add another config variable.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions