feat(overlay): added copy filename and changed styling of error frame by Shubhdeep12 · Pull Request #550 · getsentry/spotlight

Shubhdeep12 · 2024-11-05T18:06:13Z

Before opening this PR:

I added a Changeset Entry with pnpm changeset:add
I referenced issues that this PR addresses

Added copy filename button on error frame.
changed styling of error frames.

- changed styling of error frames.

vercel · 2024-11-05T18:06:17Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
spotlightjs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 1:11pm

BYK

GitHub has the copy button next to the file name so I'd rather do it that way that said they also put edit under a menu all the way to the right side. Also I don't know how this would work with long filenames so OK with right-alight for now.

Shubhdeep12 · 2024-11-06T15:41:13Z

            </span>
-          </>
-        )}
-        {isOpen && !frame.filename?.includes(':') ? (


looks like we missed this condition !frame.filename?.includes(':')

This was intentional but we can revisit the decision in the future if necessary.

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/overlay@2.7.0 ### Minor Changes - Add request and module details to context with JSONViewer ([#544](#544)) - Add support for JSON-like queries (MongoDB) while improving span details page a bit ([#563](#563)) - - Added copy filename button on error frame. ([#550](#550)) - changed styling of error frames. - - Added subtabs in trace detail page ([#557](#557)) - - Sidecar url made generic to support all sidecar server routes. ([#558](#558)) - No use of static sidecar url. ### Patch Changes - - changed route and added navigation in performance tab to make queries tab default active. ([#555](#555)) - Fixed showing of 0 in false condition in span details. - Fixed minor overlay trigger count issue ([#542](#542)) - - Fixed some conditional rendering in TraceIcon and SpanDetails which was showing 0 on UI. ([#549](#549)) - Fixed routing for query summary page by encoding the query description which can be a long text. - Fix DB queries missing for some Sentry SDKs ([#547](#547)) ## @spotlightjs/sidecar@1.9.0 ### Minor Changes - - Sidecar url made generic to support all sidecar server routes. ([#558](#558)) - No use of static sidecar url. - Create a self-contained executable for Linux, macOS, and Windows for Spotlight. ([#559](#559)) Docker images now use these binaries instead of a Node build in the image. ### Patch Changes - Fix hanging when another Spotlight server is running ([#571](#571)) ## @spotlightjs/spotlight@2.6.0 ### Minor Changes - Add CLI banner for eye candy ([#568](#568)) - Add request and module details to context with JSONViewer ([#544](#544)) - Stabilize embedded JS file name for local includes ([#553](#553)) - - Sidecar url made generic to support all sidecar server routes. ([#558](#558)) - No use of static sidecar url. - Create a self-contained executable for Linux, macOS, and Windows for Spotlight. ([#559](#559)) Docker images now use these binaries instead of a Node build in the image. ### Patch Changes - Fix DB queries missing for some Sentry SDKs ([#547](#547)) - Fix hanging when another Spotlight server is running ([#571](#571)) - Updated dependencies \[[`4d1e07eda8e5ab04db2d1e6bb14aa823e2f5d4e0`](4d1e07e), [`3ec99001202fd66a81486cc49a47452eb9e3e34b`](3ec9900), [`2e4d90c369c6345b38c085cea89142647c4b6be2`](2e4d90c), [`84f029db0e76f9295b38349f659457878df6924d`](84f029d), [`ab5181c645bcee3ab42a4f28db4daab47b5852a5`](ab5181c), [`7b9329c8c59a25cfe4cec7cbd9c6f231cf099220`](7b9329c), [`6bd2937adfcd8721af6ccd5f031860691ce6e46f`](6bd2937), [`aba5c072c59f3777c47832d1532d732237b1b9dd`](aba5c07), [`1749cb3a06576a0d94f77f0831cd088045a762fb`](1749cb3), [`5c0b1624bac267554d93bc81d17414159f0b9fe0`](5c0b162), [`c88e50edd07c56c7368ff6788bbaa938e3f9f6b8`](c88e50e)]: - @spotlightjs/overlay@2.7.0 - @spotlightjs/sidecar@1.9.0 ## @spotlightjs/astro@2.1.12 ### Patch Changes - Updated dependencies \[[`378b5c186742cb30949e5ba6342bd799b4c82b08`](378b5c1), [`2e4d90c369c6345b38c085cea89142647c4b6be2`](2e4d90c), [`ab5181c645bcee3ab42a4f28db4daab47b5852a5`](ab5181c), [`dad649a9f716d91be2665fd43f4d09497cde84c6`](dad649a), [`1749cb3a06576a0d94f77f0831cd088045a762fb`](1749cb3), [`5c0b1624bac267554d93bc81d17414159f0b9fe0`](5c0b162), [`c88e50edd07c56c7368ff6788bbaa938e3f9f6b8`](c88e50e)]: - @spotlightjs/spotlight@2.6.0 ## @spotlightjs/electron@1.1.12 ### Patch Changes - Updated dependencies \[[`4d1e07eda8e5ab04db2d1e6bb14aa823e2f5d4e0`](4d1e07e), [`3ec99001202fd66a81486cc49a47452eb9e3e34b`](3ec9900), [`2e4d90c369c6345b38c085cea89142647c4b6be2`](2e4d90c), [`84f029db0e76f9295b38349f659457878df6924d`](84f029d), [`ab5181c645bcee3ab42a4f28db4daab47b5852a5`](ab5181c), [`7b9329c8c59a25cfe4cec7cbd9c6f231cf099220`](7b9329c), [`6bd2937adfcd8721af6ccd5f031860691ce6e46f`](6bd2937), [`aba5c072c59f3777c47832d1532d732237b1b9dd`](aba5c07), [`1749cb3a06576a0d94f77f0831cd088045a762fb`](1749cb3), [`5c0b1624bac267554d93bc81d17414159f0b9fe0`](5c0b162), [`c88e50edd07c56c7368ff6788bbaa938e3f9f6b8`](c88e50e)]: - @spotlightjs/overlay@2.7.0 - @spotlightjs/sidecar@1.9.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…#550) Closes #548. ![image](https://github.com/user-attachments/assets/269c93b0-f5b7-4b85-90be-9ab88706054a) ![image](https://github.com/user-attachments/assets/f08db412-a509-4250-8e01-c001769fcb91) ![image](https://github.com/user-attachments/assets/0c09be12-7d44-4438-ab8b-2e05cf4fd03d) ![image](https://github.com/user-attachments/assets/fb051e97-032a-427d-8d8c-5f50c0b50de8) --------- Co-authored-by: Burak Yigit Kaya <byk@sentry.io>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/overlay@2.7.0 ### Minor Changes - Add request and module details to context with JSONViewer ([#544](#544)) - Add support for JSON-like queries (MongoDB) while improving span details page a bit ([#563](#563)) - - Added copy filename button on error frame. ([#550](#550)) - changed styling of error frames. - - Added subtabs in trace detail page ([#557](#557)) - - Sidecar url made generic to support all sidecar server routes. ([#558](#558)) - No use of static sidecar url. ### Patch Changes - - changed route and added navigation in performance tab to make queries tab default active. ([#555](#555)) - Fixed showing of 0 in false condition in span details. - Fixed minor overlay trigger count issue ([#542](#542)) - - Fixed some conditional rendering in TraceIcon and SpanDetails which was showing 0 on UI. ([#549](#549)) - Fixed routing for query summary page by encoding the query description which can be a long text. - Fix DB queries missing for some Sentry SDKs ([#547](#547)) ## @spotlightjs/sidecar@1.9.0 ### Minor Changes - - Sidecar url made generic to support all sidecar server routes. ([#558](#558)) - No use of static sidecar url. - Create a self-contained executable for Linux, macOS, and Windows for Spotlight. ([#559](#559)) Docker images now use these binaries instead of a Node build in the image. ### Patch Changes - Fix hanging when another Spotlight server is running ([#571](#571)) ## @spotlightjs/spotlight@2.6.0 ### Minor Changes - Add CLI banner for eye candy ([#568](#568)) - Add request and module details to context with JSONViewer ([#544](#544)) - Stabilize embedded JS file name for local includes ([#553](#553)) - - Sidecar url made generic to support all sidecar server routes. ([#558](#558)) - No use of static sidecar url. - Create a self-contained executable for Linux, macOS, and Windows for Spotlight. ([#559](#559)) Docker images now use these binaries instead of a Node build in the image. ### Patch Changes - Fix DB queries missing for some Sentry SDKs ([#547](#547)) - Fix hanging when another Spotlight server is running ([#571](#571)) - Updated dependencies \[[`4d1e07eda8e5ab04db2d1e6bb14aa823e2f5d4e0`](4d1e07e), [`3ec99001202fd66a81486cc49a47452eb9e3e34b`](3ec9900), [`2e4d90c369c6345b38c085cea89142647c4b6be2`](2e4d90c), [`84f029db0e76f9295b38349f659457878df6924d`](84f029d), [`ab5181c645bcee3ab42a4f28db4daab47b5852a5`](ab5181c), [`7b9329c8c59a25cfe4cec7cbd9c6f231cf099220`](7b9329c), [`6bd2937adfcd8721af6ccd5f031860691ce6e46f`](6bd2937), [`aba5c072c59f3777c47832d1532d732237b1b9dd`](aba5c07), [`1749cb3a06576a0d94f77f0831cd088045a762fb`](1749cb3), [`5c0b1624bac267554d93bc81d17414159f0b9fe0`](5c0b162), [`c88e50edd07c56c7368ff6788bbaa938e3f9f6b8`](c88e50e)]: - @spotlightjs/overlay@2.7.0 - @spotlightjs/sidecar@1.9.0 ## @spotlightjs/astro@2.1.12 ### Patch Changes - Updated dependencies \[[`378b5c186742cb30949e5ba6342bd799b4c82b08`](378b5c1), [`2e4d90c369c6345b38c085cea89142647c4b6be2`](2e4d90c), [`ab5181c645bcee3ab42a4f28db4daab47b5852a5`](ab5181c), [`dad649a9f716d91be2665fd43f4d09497cde84c6`](dad649a), [`1749cb3a06576a0d94f77f0831cd088045a762fb`](1749cb3), [`5c0b1624bac267554d93bc81d17414159f0b9fe0`](5c0b162), [`c88e50edd07c56c7368ff6788bbaa938e3f9f6b8`](c88e50e)]: - @spotlightjs/spotlight@2.6.0 ## @spotlightjs/electron@1.1.12 ### Patch Changes - Updated dependencies \[[`4d1e07eda8e5ab04db2d1e6bb14aa823e2f5d4e0`](4d1e07e), [`3ec99001202fd66a81486cc49a47452eb9e3e34b`](3ec9900), [`2e4d90c369c6345b38c085cea89142647c4b6be2`](2e4d90c), [`84f029db0e76f9295b38349f659457878df6924d`](84f029d), [`ab5181c645bcee3ab42a4f28db4daab47b5852a5`](ab5181c), [`7b9329c8c59a25cfe4cec7cbd9c6f231cf099220`](7b9329c), [`6bd2937adfcd8721af6ccd5f031860691ce6e46f`](6bd2937), [`aba5c072c59f3777c47832d1532d732237b1b9dd`](aba5c07), [`1749cb3a06576a0d94f77f0831cd088045a762fb`](1749cb3), [`5c0b1624bac267554d93bc81d17414159f0b9fe0`](5c0b162), [`c88e50edd07c56c7368ff6788bbaa938e3f9f6b8`](c88e50e)]: - @spotlightjs/overlay@2.7.0 - @spotlightjs/sidecar@1.9.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

- Added copy filename button on error frame.

bc451c4

- changed styling of error frames.

Shubhdeep12 requested a review from BYK November 5, 2024 18:06

Shubhdeep12 enabled auto-merge (squash) November 5, 2024 18:06

BYK reviewed Nov 6, 2024

View reviewed changes

Comment thread .changeset/shaggy-dodos-sparkle.md Outdated

It's a minor upgrade not patch

5a5b805

vercel Bot deployed to Preview November 6, 2024 12:01 View deployment

some more refactoring

0e7168b

vercel Bot had a problem deploying to Preview November 6, 2024 12:37 Failure

add missing file

c317412

vercel Bot had a problem deploying to Preview November 6, 2024 12:40 Failure

BYK added 2 commits November 6, 2024 12:43

fix paths

2356a04

fix issues with filenames & refactor

ee4aff2

vercel Bot deployed to Preview November 6, 2024 13:11 View deployment

BYK approved these changes Nov 6, 2024

View reviewed changes

BYK disabled auto-merge November 6, 2024 13:11

BYK enabled auto-merge (squash) November 6, 2024 13:12

BYK merged commit 6bd2937 into main Nov 6, 2024

BYK deleted the shubhdeep12/feat/error-frames branch November 6, 2024 13:14

Shubhdeep12 commented Nov 6, 2024

View reviewed changes

Shubhdeep12 mentioned this pull request Nov 6, 2024

fix(overlay): UI fixes. #555

Merged

1 of 2 tasks

getsentry-release mentioned this pull request Nov 26, 2024

meta(changelog): Update package versions #573

Merged

Navigation Menu

Uh oh!

feat(overlay): added copy filename and changed styling of error frame - #550

feat(overlay): added copy filename and changed styling of error frame#550
BYK merged 6 commits into
mainfrom
shubhdeep12/feat/error-frames

Shubhdeep12 commented Nov 5, 2024

Uh oh!

vercel Bot commented Nov 5, 2024 •

edited

Loading

Uh oh!

Uh oh!

BYK left a comment

Uh oh!

Shubhdeep12 Nov 6, 2024

Uh oh!

BYK Nov 6, 2024

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Shubhdeep12 commented Nov 5, 2024

Uh oh!

vercel Bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

BYK left a comment

Choose a reason for hiding this comment

Uh oh!

Shubhdeep12 Nov 6, 2024

Choose a reason for hiding this comment

Uh oh!

BYK Nov 6, 2024

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Nov 5, 2024 •

edited

Loading