feat(slack): include Slack user mention in post notifications - #194
Draft
cleptric wants to merge 1 commit into
Draft
feat(slack): include Slack user mention in post notifications#194cleptric wants to merge 1 commit into
cleptric wants to merge 1 commit into
Conversation
Add a slackUserId field to the User model so post notification messages sent to Slack channels use `<@userid>` instead of a plain display name. This lets Slack resolve the mention to a live profile and notify the author. - Add nullable `slackUserId` column to the User table - Expose it in PUBLIC_USER_COLUMNS and PostAuthor type - notify() in slack.ts prefers `<@slackUserId>` over getDisplayName() - Admin user profile page gains a Slack User ID input field - Drizzle migration 0001_add_user_slack_user_id.sql Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
slackUserIdfield to theUsermodel so that Slack post notifications include a proper<@USERID>mention instead of a plain display name. This makes the mention clickable in Slack and notifies the author.Changes
app/db/schema.ts— nullableslackUserId textcolumn onUserapp/models/user.server.ts— exposesslackUserIdinPUBLIC_USER_COLUMNSandupdateUser()app/models/post.server.ts— addsslackUserIdtoPostAuthortypeapp/lib/slack.ts—notify()uses<@slackUserId>when set, falls back togetDisplayName()app/routes/u.$userEmail._index.tsx— admin user profile page gets a "Slack User ID" inputdrizzle/0001_add_user_slack_user_id.sql— migration:ALTER TABLE "User" ADD COLUMN "slackUserId" textHow to set a user's Slack ID
Admins can set it via the user profile page (
/u/<email>) → Admin panel → Slack User ID field. The ID format is e.g.U03SQM83ML2.View Session in Sentry