feature: lua 'script_templates' - #238
Conversation
|
Hi @howhow2315, thanks a lot for the contribution! Sorry it took me so long to review, lots of stuff happened these last weeks 😅
There's the LuaScriptLanguage::_get_built_in_templates method that returns script templates. Right now it only ships the "Default" and "Empty" templates. I think rather than adding a separate plugin that copies script templates to the project's script template folder, a simpler approach would be to change Another thing, what's the use case for the |
|
the reason theres mostly comments on my thought processes rather than fact checking is 70% of this was done on a plane without wifi lol |
Hey @howhow2315 , don't worry. We are all here to make Lua GDExtension the best it can be and I really appreciate the the help! We should definitely have better support for script templates, so I'm sure we can make something that works for not only both of us, but for all users in general =]
I don't think LuaJIT would be any different from Lua here. If you do, I'm really curious to know why (although you don't need to bother explaining if you don't want to). |
a simple addition that adds a plugin (tool) which dynamically imports solid Lua script_templates
as apart of this i refactored the lua_repl into a subfolder so the two plugins can coexist
if theres script_templates that are included somewhere in the source code that i missed thatd be very awkward! but i considered that while making this and thought it might be more user friendly to have it be optional like this