Skip to content

Fixes typo in Castilian translation#956

Closed
cleydyr wants to merge 17 commits into
gitgitgadget:masterfrom
cleydyr:fix-typo-es
Closed

Fixes typo in Castilian translation#956
cleydyr wants to merge 17 commits into
gitgitgadget:masterfrom
cleydyr:fix-typo-es

Conversation

@cleydyr

@cleydyr cleydyr commented May 18, 2021

Copy link
Copy Markdown

No description provided.

alexhenrie and others added 5 commits May 14, 2021 21:14
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Generate po/git.pot from v2.32.0-rc0 for git v2.32.0 l10n round 1.

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Vincent Tam <sere@live.hk>
Signed-off-by: rlespinasse <romain.lespinasse@gmail.com>
Signed-off-by: Emir Sarı <bitigchi@me.com>
@gitgitgadget

gitgitgadget Bot commented May 18, 2021

Copy link
Copy Markdown

Welcome to GitGitGadget

Hi @cleydyr, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that your Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

  • the lines should not exceed 76 columns,
  • the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
  • the commit messages' body should be describing the "why?" of the change.
  • Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the FreeNode IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Freenode. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

@gitgitgadget

gitgitgadget Bot commented May 18, 2021

Copy link
Copy Markdown

There is an issue in commit 365a65d:
Commit checks stopped - the message is too short

@dscho

dscho commented May 18, 2021

Copy link
Copy Markdown
Member

jnavila and others added 12 commits May 19, 2021 18:58
Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
Find typos in "po/TEAMS" file using the "git-po-helper" program.  These
typos were introduced from commit v2.24.0-1-g9917eca794 (l10n: zh_TW:
add translation for v2.24.0, 2019-11-20 19:14:22 +0800).

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Peter Krefting <peter@softwolves.pp.se>
Signed-off-by: Yi-Jyun Pan <pan93412@gmail.com>
Signed-off-by: Yi-Jyun Pan <pan93412@gmail.com>
Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>
Translate following components:

  * builtin/add.c
  * worktree.c
  * builtin/branch.c
  * builtin/commit.c
  * builtin/merge.c
  * builtin/rebase.c
  * builtin/pull.c
  * diff.c
  * add-interactive.c
  * builtin/log.c
  * builtin/stash.c
  * builtin/tag.c
  * config.c
  * builtin/config.c
  * reset.c
  * builtin/remote.c
  * builtin/rm.c
  * builtin/mv.c
  * builtin/clean.c
  * builtin/help.c
  * archive.c
  * submodule.c
  * builtin/submodule--helper.c
  * submodule-config.c

Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
* 'fr_next' of github.com:jnavila/git:
  l10n: fr: v2.32.0 round 1
  l10n: fr: fixed inconsistencies
  l10n: fr.po fixed inconsistencies
Signed-off-by: Alexander Shopov <ash@kambanaria.org>
* 'master' of github.com:Softcatala/git-po:
  l10n: Update Catalan translation
* 'l10n/zh_TW/21-05-20' of github.com:l10n-tw/git-po:
  l10n: zh_TW.po: localized
  l10n: zh_TW.po: v2.32.0 round 1 (11 untranslated)
Signed-off-by: Cleydyr Albuquerque <cleydyr@gmail.com>
@gitgitgadget

gitgitgadget Bot commented May 31, 2021

Copy link
Copy Markdown

Invalid author email in 9bafe04: "VincentTam@users.noreply.github.com"

@gitgitgadget

gitgitgadget Bot commented May 31, 2021

Copy link
Copy Markdown

There are merge commits in this Pull Request:

c2529290f05b472c1710f3a3c5ccdbf1258d248d
e94005634c881446a4e15ee71c1e7aa02748daf2
3d33e36c47ce563b2d52062b928e525726b9b944

Please rebase the branch and force-push.

@dscho

dscho commented Jun 1, 2021

Copy link
Copy Markdown
Member

As per https://github.com/git/git/blob/v2.31.1/po/README, would you kindly open a PR at https://github.com/git-l10n/git-po/?

If you did that, could you close this here PR, please?

@cleydyr cleydyr closed this Jun 1, 2021
dscho added a commit that referenced this pull request Jul 16, 2026
Users were noticing some cases of infinite loops with the error message:

```
fatal: recursion detected in die handler
```

It's only happening for repos with a post-command hook, but it's not
deterministic. I'm not sure what is triggering the problem, but the
post-command hook is definitely able to recurse with its existing logic
around the `run_post_hook` variable.

Move this earlier to avoid a potential double-call. It's a fixup to the
introduction of the method, which may cause conflicts with later
adjustments to this method still in the branch thicket (but maybe those
should be squashed, too).

See #955 for the version on 2.54.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.