fix: add small guide for ctrl as VM in libvirt - #324
Merged
Conversation
|
🚀 Deployed on https://preview-324--hedgehog-docs.netlify.app |
There was a problem hiding this comment.
Pull request overview
Adds guidance to the installation docs for running the Control Node (“controller”) as a VM, while clarifying that this setup is not officially supported.
Changes:
- Adds a “Controller as Virtual Machine” section with libvirt-oriented recommendations.
- Adds a cross-reference from the “Install Control Node” section to the new VM guidance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+133
to
+140
| - Disable secure boot: | ||
| ```xml | ||
| <os firmware='efi'> | ||
| <firmware> | ||
| <feature enabled='no' name='secure-boot'/> | ||
| </firmware> | ||
| </os> | ||
| ``` |
Comment on lines
+89
to
+92
| This control node should be given a static IP address. Either a lease or | ||
| statically assigned. Running the control node as a virtual machine isn't | ||
| officially supported but there are recommendations [in this | ||
| section](#controller-as-virtual-machine). |
mrbojangles3
force-pushed
the
logan/controllerVM
branch
from
July 21, 2026 14:06
b6435c7 to
7689f65
Compare
Frostman
requested changes
Jul 22, 2026
Frostman
left a comment
Member
There was a problem hiding this comment.
Should we make some separate page under the install-upgrade section with a notice that while VM controller isn't officially supported, here are the recommendations on how to run it
Signed-off-by: Logan Blyth <logan@githedgehog.com>
Signed-off-by: Logan Blyth <logan@githedgehog.com>
mrbojangles3
force-pushed
the
logan/controllerVM
branch
4 times, most recently
from
July 29, 2026 19:45
ede6e27 to
26ecf26
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
docs/install-upgrade/virtual-machines.md:42
- The sentence about gateway performance is grammatically incorrect ("There are no minimum performance guarantee"). This should be singular ("There is no") or pluralize "guarantees".
- There are no minimum performance guarantee when the gateway is in a VM.
docs/install-upgrade/install.md:99
- This reads like a sentence fragment and includes trailing whitespace. Consider rephrasing to clearly describe how to ensure a stable IP (DHCP reservation vs. static config) and remove the extra trailing space.
This control node should be given a static IP address. Either a lease or
statically assigned.
Signed-off-by: Logan Blyth <logan@githedgehog.com>
Signed-off-by: Logan Blyth <logan@githedgehog.com>
Signed-off-by: Logan Blyth <logan@githedgehog.com>
mrbojangles3
force-pushed
the
logan/controllerVM
branch
from
July 29, 2026 21:09
26ecf26 to
ed4a9bf
Compare
Frostman
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #322