Shared: Shadow isAfterValue on ControlFlowNode. - #22288
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The focused API addition is consistent with its stated purpose and has clear documentation.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Adds safer post-construction value-state queries to ControlFlowNode.
Changes:
- Shadows three
PreControlFlowNodepredicates with CFG-specific semantics. - Documents the semantic distinction.
File summaries
| File | Description |
|---|---|
shared/controlflow/codeql/controlflow/ControlFlowGraph.qll |
Adds and documents the three shadowing predicates. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
hvitved
approved these changes
Aug 6, 2026
hvitved
left a comment
Contributor
There was a problem hiding this comment.
LGTM, good with the comment that explains the differences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can actually be nice to to use
isAfterValueonControlFlowNodepost CFG construction. But in those use-cases the semantics you want (and expect) is actually different from what's onPreControlFlowNode. And usingPreControlFlowNode::isAfterValueafter the CFG is constructed is almost guaranteed to be wrong. Fortunately we can simply shadow the predicates to get a more useful and safer API sincePreControlFlowNodeisfinal.The 3 added predicates are not used anywhere yet.