Refactor external agent runtime lifecycle - #7129
Open
lpcox wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
✨ New Files (3 files)
Coverage comparison generated by |
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces an external runtime lifecycle abstraction while preserving Compose handling for Docker and gVisor.
Changes:
- Adds backend contracts, resolution, and adaptation.
- Moves sbx lifecycle logic out of
main-action. - Adds lifecycle tests and extension documentation.
Show a summary per file
| File | Description |
|---|---|
src/sbx-runtime-backend.ts |
Implements the sbx backend lifecycle. |
src/sbx-runtime-backend.test.ts |
Tests sbx lifecycle behavior. |
src/external-runtime-backend.ts |
Defines and adapts external backends. |
src/external-runtime-backend.test.ts |
Tests resolution and adaptation. |
src/external-runtime-backend-resolver.ts |
Registers and resolves backends. |
src/container-runtime.ts |
Updates microVM extension guidance. |
src/commands/main-action.ts |
Integrates backend execution and cleanup. |
src/commands/main-action.test.ts |
Tests resolver failure handling. |
src/commands/main-action-coverage-gaps.test.ts |
Tests external-backend signal handling. |
src/cli-workflow.ts |
Exports the workflow dependency contract. |
docs/sbx-integration.md |
Documents backend registration. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 11/11 changed files
- Comments generated: 1
- Review effort level: Balanced
This was referenced Aug 9, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
✅ Copilot review passed with no inline comments. @lpcox Add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack layer 1/6.
main-actionBehavior is intentionally unchanged for Docker, gVisor, and sbx, including API-proxy reflection, credential environment handling, diagnostics, timeout/TTY behavior, keep-containers semantics, and exit-code propagation.
Validation
tsc --noEmit -p tsconfig.check.jsonnpm run buildStack