[Contribution Check Report] Contribution Check — 2026-04-05

[github-actions]

We reviewed the open pull requests in github/gh-aw — no external contributor PRs matched the filter criteria this run.

---

All open PRs were authored by automation accounts (github-actions[bot], Copilot) and were excluded from contribution checking. There are no PRs requiring maintainer review at this time.

---

Evaluated: 0 · Skipped: 6 · Run: https://github.com/github/gh-aw/actions/runs/23991483142

Generated by Contribution Check · ● 490.5K · ◷

• expires on Apr 6, 2026, 1:22 AM UTC

[github-actions]

Contribution Check Report — PR #24503

Field	Value
Verdict	🟢 Aligned
Quality	needs-work
Author	Copilot
On-topic	✅ yes
Follows process	✅ yes (core-team agent PR)
Focused	✅ yes
New deps	✅ no
Has tests	⚠️ no (Go unit tests missing)
Lines changed	894
Existing labels	smoke-claude, smoke-copilot

Notes

The PR introduces a substantial, well-described new feature (tools.mount-as-clis) following established project patterns. It is clearly on-topic, authored by the Copilot agent (core team), and tightly scoped to a single feature.

Gap identified: A new shell-test file (validate_prompt_placeholders_test.sh) is included for the shell-script bugfix, but there is no Go unit test file for the primary new Go code (pkg/workflow/mcp_cli_mount.go, tools_parser.go, tools_types.go). The repo pattern is to have a *_test.go per feature file — every adjacent MCP module (mcp_detection.go, mcp_rendering.go, mcp_gateway_config.go, etc.) has a corresponding test file. The three new exported functions in mcp_cli_mount.go (getMCPCLIServerNames, generateMCPCLIMountStep, buildMCPCLIPromptSection) have no test coverage.

Generated by Contribution Check · ● 1.2M · ◷

• expires on Apr 6, 2026, 5:35 AM UTC

[github-actions]

Contribution Check Report for PR #24685

PR: docs: add pre-step data-fetching pattern to create-agentic-workflow.md
Author: @Copilot | Verdict: ⚠️ Needs Focus | Quality: needs-work

---

Checklist

Check	Result
On-topic	✅ yes
Follows process	✅ yes
Focused	❌ no
New dependencies	✅ no
Has tests	❌ no
Has description	✅ yes
Lines changed	166 (97 additions + 69 deletions)

---

Findings

⚠️ Unfocused diff — two unrelated changes bundled together:

1. .github/aw/create-agentic-workflow.md — adds the new ### Pre-step Data Fetching subsection (the stated goal of the PR).
2. pkg/agentdrain/data/default_weights.json — reformats multi-line JSON arrays to single-line format across ~7 locations. This is a purely cosmetic change with no functional impact and is completely unrelated to the documentation addition. It is not mentioned anywhere in the PR description.

The JSON reformatting should either be reverted (if it was an accidental side-effect) or split into its own separate PR with a clear rationale.

Draft state: The PR is currently in draft. It should only be marked ready for review once the scope issue is resolved.

---

Suggested Fix

Remove the pkg/agentdrain/data/default_weights.json changes from this PR to keep it focused on the documentation goal, or open a dedicated PR for the JSON reformatting with a description of why the style change is beneficial.

Generated by Contribution Check · ● 1.9M · ◷

• expires on Apr 6, 2026, 9:11 AM UTC

[github-actions]

Contribution Check — 2026-04-05

No new human-authored PRs were found that matched the contribution check filters. All currently open PRs are from automated agents (github-actions[bot] and Copilot).

---

Nothing to review at this time. The next run will pick up any new external contributions.

---

Evaluated: 0 · Skipped: 6 · Run: 24002277667

Generated by Contribution Check · ● 383.6K · ◷

• expires on Apr 6, 2026, 1:17 PM UTC

[github-actions]

Contribution Check Report

Field	Value
PR	#24757 — Add checks as a first-class MCP tool to the gh-aw MCP server
Author	Copilot
Verdict	🟢 Aligned
Quality	needs-work
On-topic	yes
Focused	yes
New deps	no
Has tests	no
Lines changed	~89 additions
Existing labels	(none)

---

Checklist Details

1. On-topic — ✅ Yes. Adding checks as a first-class MCP tool directly aligns with the project's core mission. The PR body even explains the exact gap: the gh-aw MCP server exposed 8 tools but omitted checks, forcing review workflows to shell out to gh aw checks.

2. Follows process — ✅ Yes. The PR was opened by the Copilot coding agent, which is the intended and documented contribution method for this project.

3. Focused — ✅ Yes. The diff touches exactly one feature area: registering registerChecksTool, documenting it, and updating the help text. No unrelated changes.

4. New dependencies — ✅ No. No changes to go.mod or go.sum.

5. Has tests — ❌ No. Zero test files changed in the diff.

---

Issues Found

Missing: unit test for registerChecksTool

pkg/cli/status_mcp_integration_test.go provides the established pattern (TestGetWorkflowStatuses_MCPIntegration / TestGetWorkflowStatuses_WithPattern). An equivalent checks_mcp_integration_test.go is absent.

Existing integration test would break

pkg/cli/mcp_server_tools_test.go hardcodes the expected tool list and asserts an exact count:

expectedTools := []string{"status", "compile", "logs", "audit", "mcp-inspect", "add", "update", "fix"}
// ...
if len(result.Tools) != len(expectedTools) {   // expects 8, will get 9
    t.Errorf("Expected %d tools, got %d", len(expectedTools), len(result.Tools))
}

After this PR, the server exposes 9 tools but the test still expects 8 and does not include "checks" in expectedTools. This will cause the integration test to fail.

Generated by Contribution Check · ● 2.3M · ◷

• expires on Apr 6, 2026, 5:09 PM UTC

[github-actions]

Contribution Check Report

Field	Value
PR	#24697
Author	@Copilot
Verdict	🟢 Aligned
Quality	lgtm
On-topic	✅ yes
Focused	✅ yes
Follows process	✅ yes
New deps	✅ no
Has tests	✅ yes
Has description	✅ yes
Lines changed	1,119 (954 additions / 165 deletions)
Existing labels	smoke-claude, smoke-copilot

---

Checklist Breakdown

1. On-topic — yes. Wiring OpenTelemetry OTLP tracing into the MCP gateway falls squarely within the project's core domain (agentic workflow infrastructure).

2. Follows process — yes. The PR author is Copilot (the copilot-swe-agent GitHub App), which is exactly the process CONTRIBUTING.md prescribes: "Core team uses agents to create and manage pull requests."

3. Focused — yes. The diff is cohesive: it threads OTLP config from frontmatter through the compiler and into the gateway runtime config. The 55 lock-file changes are auto-generated artefacts of the underlying Go/workflow changes — not unrelated additions.

4. New deps — no. No changes to go.mod, go.sum, or any other dependency manifest.

5. Has tests — yes. pkg/workflow/observability_otlp_test.go is included in the diff with 48 additions.

6. Has description — yes. The PR body is thorough: it references the spec section (§4.1.3.6), lists every changed file with rationale, shows the runtime config produced, and explains the bash header-conversion preamble.

7. Diff size — 1,119 lines (954 + 165). Substantial but proportionate to an end-to-end feature spanning parser, compiler, and renderer layers.

---

Verdict: 🟢 Aligned / lgtm

No negative checklist conditions were triggered. The PR is authored by the project's own coding agent following established core-team process, is well-described, includes tests, introduces no new dependencies, and targets a single coherent feature area.

Generated by Contribution Check · ● 1.2M · ◷

• expires on Apr 6, 2026, 9:06 PM UTC

[github-actions]

This issue is being closed as outdated. A newer issue has been created: #24804

View newer issue

---

This action was performed automatically by the Contribution Check workflow.