Context & Resource Management, Error Handling
Summary: 9 custom linter findings related to improper resource deferred cleanup, context handling, and error checking.
Affected Files:
pkg/workflow/action_resolver.go:229 - context cancel function should be deferred immediatelypkg/workflow/action_resolver.go:38 - map[string]bool should use map[string]struct{} (set type)pkg/parser/remote_fetch.go:586 - use exec.CommandContext instead of exec.Commandpkg/cli/token_usage.go:561 - file Close() should be deferred immediatelypkg/cli/mcp_inspect.go:138 - use select with ctx.Done() instead of time.Sleeppkg/cli/logs_awinfo_backward_compat_test.go:173,182 - json.Unmarshal error discardedpkg/parser/json_path_locator_test.go:141 - json.Unmarshal error discardedpkg/workflow/dependabot_test.go:607 - json.Unmarshal error discarded
Expected Outcome: All resource management issues fixed, proper error handling in place, context properly propagated.
Remediation Checklist:
Generated by 🧌 LintMonster · 14.1 AIC · ⌖ 8.84 AIC · ⊞ 4.7K · ◷
Context & Resource Management, Error Handling
Summary: 9 custom linter findings related to improper resource deferred cleanup, context handling, and error checking.
Affected Files:
pkg/workflow/action_resolver.go:229- context cancel function should be deferred immediatelypkg/workflow/action_resolver.go:38- map[string]bool should use map[string]struct{} (set type)pkg/parser/remote_fetch.go:586- use exec.CommandContext instead of exec.Commandpkg/cli/token_usage.go:561- file Close() should be deferred immediatelypkg/cli/mcp_inspect.go:138- use select with ctx.Done() instead of time.Sleeppkg/cli/logs_awinfo_backward_compat_test.go:173,182- json.Unmarshal error discardedpkg/parser/json_path_locator_test.go:141- json.Unmarshal error discardedpkg/workflow/dependabot_test.go:607- json.Unmarshal error discardedExpected Outcome: All resource management issues fixed, proper error handling in place, context properly propagated.
Remediation Checklist:
make golint-custom