Skip to content

[plan] Fix trial_confirmation.go sub-step bullets to use console.FormatListItemStderr #43577

Description

@github-actions

Objective

Replace the two unformatted sub-step bullet lines in pkg/cli/trial_confirmation.go with console.FormatListItemStderr (or a new FormatSubItemStderr helper) to match the formatting style used by surrounding steps.

Context

Identified in Terminal Stylist analysis: discussion #43520. Lines 182–183 and 199–200 in trial_confirmation.go use fmt.Fprintf(os.Stderr, " a./b. ...") sub-bullets. The surrounding step lines already use console.FormatInfoMessage, so these two callsites are visually inconsistent.

Implementation Plan

Files to Modify

  • pkg/cli/trial_confirmation.go lines 182–183, 199–200

Approach

  1. Review how the surrounding step lines format output (likely using console.FormatInfoMessage or similar).
  2. Replace fmt.Fprintf(os.Stderr, " a./b. ...") callsites with console.FormatListItemStderr with an appropriate indent, OR add a thin FormatSubItemStderr helper to pkg/console/ if needed.
  3. If a new helper is warranted, add it to pkg/console/console.go (or a suitable file in that package) following the existing pattern of other format helpers.
  4. Run make build and existing tests.

Notes

  • Blank-line spacers (fmt.Fprintln(os.Stderr, "") at lines 220–222) should be left as-is.
  • Match the visual indentation/prefix used by the surrounding step output for a cohesive look.

Acceptance Criteria

  • Lines 182–183 and 199–200 no longer use raw fmt.Fprintf(os.Stderr, ...)
  • Sub-step bullets visually match surrounding console.FormatInfoMessage steps
  • Build passes and existing tests pass

Generated by 📋 Plan Command · 25.5 AIC · ⌖ 8.2 AIC · ⊞ 4.9K ·
Comment /plan to run again

  • expires on Jul 7, 2026, 7:23 AM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions