Skip to content

[eslint-monster] [lint-monster] setup/js: numeric coercion, setOutput stringification, and async entrypoint cleanup #43634

Description

@github-actions

Scope

Remediate remaining correctness/style warnings under actions/setup/js that cluster around numeric parsing/coercion, core.setOutput(...) value types, and bare async entrypoints.

Affected files

  • actions/setup/js/assign_copilot_to_created_issues.cjs
  • actions/setup/js/assign_milestone.cjs
  • actions/setup/js/assign_to_agent.cjs
  • actions/setup/js/autofix_code_scanning_alert.cjs
  • actions/setup/js/check_skip_if_check_failing.cjs
  • actions/setup/js/check_skip_if_helpers.cjs
  • actions/setup/js/check_stop_time.cjs
  • actions/setup/js/close_entity_helpers.cjs
  • actions/setup/js/close_issue.cjs
  • actions/setup/js/close_pull_request.cjs
  • actions/setup/js/create_code_scanning_alert.cjs
  • actions/setup/js/create_discussion.cjs
  • actions/setup/js/create_issue.cjs
  • actions/setup/js/create_pr_review_comment.cjs
  • actions/setup/js/create_project_status_update.cjs
  • actions/setup/js/ephemerals.cjs
  • actions/setup/js/error_recovery.cjs
  • actions/setup/js/generate_usage_activity_summary.cjs
  • actions/setup/js/github_rate_limit_logger.cjs
  • actions/setup/js/merge_remote_agent_github_folder.cjs
  • actions/setup/js/parse_codex_log.cjs
  • actions/setup/js/parse_mcp_gateway_log.cjs
  • actions/setup/js/parse_mcp_scripts_logs.cjs
  • actions/setup/js/parse_token_usage.cjs
  • actions/setup/js/safe_output_handler_manager.cjs
  • actions/setup/js/safe_output_helpers.cjs
  • actions/setup/js/safe_output_type_validator.cjs
  • actions/setup/js/safe_output_validator.cjs

Representative diagnostics

  • assign_to_agent.cjs:57 — prefer Number.isNaN(...) over global isNaN(...).
  • parse_codex_log.cjs:32parseInt() must be called with an explicit radix.
  • create_code_scanning_alert.cjs:263setOutput value should be explicitly stringified.
  • safe_output_handler_manager.cjs:1382 — numeric literal passed to setOutput should be converted explicitly.
  • merge_remote_agent_github_folder.cjs:438 — bare main() call needs .catch(...).

Expected outcome

Setup runtime scripts should avoid coercive numeric APIs, provide explicit radix/string conversions, and ensure async entrypoints surface rejections predictably.

Checklist

  • Replace global isNaN(...) with Number.isNaN(...) patterns that preserve intended semantics
  • Add explicit radix arguments to every parseInt(...)
  • Make core.setOutput(...) values explicit strings where required
  • Add .catch(...) wrappers to bare async entrypoints
  • Keep changes scoped to actions/setup/js
  • Run npm run lint:setup-js

Generated by 🧹 ESLint Monster · 18.5 AIC · ⌖ 7.96 AIC · ⊞ 1.5K ·

  • expires on Jul 12, 2026, 2:18 PM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions