Skip to content

[deep-report] [Code Quality] Extract shared base for AccessLogSummary/FirewallLogSummary in logs_report_firewall.go #46025

Description

@github-actions

Description

pkg/cli/logs_report_firewall.go declares two ~80%-overlapping summary structs:

  • AccessLogSummary (line ~11)
  • FirewallLogSummary (line ~21)

Both carry TotalRequests, allowed/blocked counters, AllowedDomains, BlockedDomains, and ByWorkflow. They differ only in counter field naming (AllowedCount/BlockedCount vs AllowedRequests/BlockedRequests) and one extra RequestsByDomain map on the firewall variant. Extract a shared base struct, align the counter field names, and embed it in both.

Expected Impact

Removes parallel-maintenance drift between two firewall summary types. Bounded, single-file refactor.

Suggested Agent

Code Quality agent (Go refactor).

Estimated Effort

Medium (1-2 hours)

Data Source

DeepReport Intelligence Briefing 2026-07-16, from the [typist] Go Type Consistency report (Cluster 4). Verified un-filed as of this run.

Generated by 🔬 Deep Report · 247.5 AIC · ⌖ 12.4 AIC · ⊞ 10K ·

  • expires on Jul 18, 2026, 7:30 AM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions