Skip to content

[deep-report] [Code Quality] Extract shared analysis base for DomainAnalysis/FirewallAnalysis (access_log.go/firewall_log.go) #46026

Description

@github-actions

Description

Two near-duplicate firewall analysis structs both embed DomainBuckets + TotalRequests + allowed/blocked counts and implement AddMetrics(LogAnalysis):

  • pkg/cli/access_log.go:34DomainAnalysis
  • pkg/cli/firewall_log.go:133FirewallAnalysis (only adds RequestsByDomain)

Extract a shared analysis base and embed it in both, removing the parallel AddMetrics maintenance.

Expected Impact

One analysis base instead of two hand-synced structs; less drift risk in firewall log processing.

Suggested Agent

Code Quality agent (Go refactor).

Estimated Effort

Medium (1-2 hours)

Data Source

DeepReport Intelligence Briefing 2026-07-16, from the [typist] Go Type Consistency report (Cluster 5). Verified un-filed as of this run.

Generated by 🔬 Deep Report · 247.5 AIC · ⌖ 12.4 AIC · ⊞ 10K ·

  • expires on Jul 18, 2026, 7:30 AM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions