Skip to content

[Code Quality] Document why WASM builds skip repository feature validation #48712

Description

@github-actions

Description

The file pkg/workflow/repository_features_validation_wasm.go is a bare 12-line stub (build-tagged js || wasm) whose validateRepositoryFeatures function always returns nil. There is no explanation for why WASM builds skip the real validation that the native compiler presumably performs (checking HasDiscussions/HasIssues against the GitHub API).

This undocumented behavioral difference between build targets can confuse maintainers who see inconsistent validation results between the CLI and the WASM playground.

Suggested Changes

Add a clear doc comment to pkg/workflow/repository_features_validation_wasm.go explaining the rationale for the no-op, e.g. that the WASM/playground build has no network access to query repository features via the GitHub API, so validation is intentionally skipped client-side (and should be documented as such on both the type and the function).

Files Affected

  • pkg/workflow/repository_features_validation_wasm.go

Success Criteria

  • Doc comments added explaining why WASM builds no-op this validation
  • No functional/behavioral change
  • make fmt and go build ./... succeed

Source

Extracted from User Experience Analysis Report discussion #48665

Priority

Low - documentation clarity improvement, not blocking

🔍 Task mining by Discussion Task Miner - Code Quality Improvement Agent · sonnet50 · 35.9 AIC · ⌖ 4.29 AIC · ⊞ 9.8K ·

  • expires on Jul 29, 2026, 11:12 AM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions