[lint-monster] function-length refactoring backlog (656 current findings)

[github-actions]

Overview

Daily make golint-custom found 656 function-length (largefunc) findings in the shared backlog across pkg/workflow, pkg/cli, and pkg/parser.

Root cause grouping

This is the single authoritative tracking issue for the shared function-length refactoring backlog. Per LintMonster policy, all long-function findings in pkg/workflow and pkg/cli are tracked together instead of being split by package, file, or snapshot.

Current finding counts

• pkg/cli: 363 findings
• pkg/workflow: 292 findings
• pkg/parser: 1 finding
• Total shared backlog: 656 findings

Representative diagnostics

• pkg/workflow/awf_command_builder.go:26: BuildAWFCommand is 395 lines long (limit 60).
• pkg/workflow/awf_config.go:468: BuildAWFConfigJSON is 302 lines long (limit 60).
• pkg/workflow/safe_outputs_config_extraction.go:45: extractSafeOutputsConfig is 370 lines long (limit 60).
• pkg/cli/add_wizard_command.go:15: NewAddWizardCommand is 123 lines long (limit 60).
• pkg/cli/audit_diff.go:625: computeToolCallsDiff is 131 lines long (limit 60).
• pkg/parser/schema_suggestions.go:539: extractNestedYAMLValue is 73 lines long (limit 60).

Expected outcome

Reduce this backlog incrementally with small, behavior-preserving refactors that extract helpers, split decision blocks, and keep each change narrowly scoped.

Next refactor slices

• Refactor pkg/workflow/awf_command_builder.go (BuildAWFCommand, BuildAWFArgs).
• Refactor pkg/workflow/awf_config.go (BuildAWFConfigJSON).
• Refactor pkg/workflow/safe_outputs_config_extraction.go (extractSafeOutputsConfig).
• Refactor pkg/workflow/compiler_* long builders in small file-by-file slices.
• Refactor pkg/cli/add_* interactive helpers in small slices.
• Refactor pkg/cli/audit_* render/diff helpers in small slices.
• Refactor pkg/cli/update_* command helpers in small slices.
• Refactor pkg/parser/schema_suggestions.go (extractNestedYAMLValue).

Remediation checklist

• Keep remediation scoped to a small slice of the backlog.
• Prefer minimal, targeted helper extraction over broad rewrites.
• Preserve behavior, public signatures, and existing tests.
• Run make golint-custom after the changes.
• If Go files change, run make fmt.

Fused skill guidance

• From go-linters: validate the final change with make golint-custom.
• From developer: keep remediation targeted, prefer minimal edits, and run make fmt after Go changes.
• No duplicate function-length tracking issues were found in the recent open/closed lint-monster issue set.

Generated by 🧌 LintMonster · pi · lint-monster daily scan

Generated by 🧌 LintMonster · gpt54 · 29 AIC · ⌖ 4.44 AIC · ⊞ 5.7K · ◷

• expires on Aug 18, 2026, 7:22 PM UTC-08:00