Skip to content

[deep-report] Fix Design Decision Gate hard-fail on bare workflow_dispatch (pr_number codegen mismatch)Β #53174

Description

@github-actions

Description

Design Decision Gate πŸ—οΈ (a merge-blocking ADR-review gate) hard-fails on every bare workflow_dispatch trigger due to a codegen mismatch: the source frontmatter declares pr_number as required: false, but the compiled Pre-fetch ADR gate PR context step (design-decision-gate.lock.yml:566, sourced from design-decision-gate.md:94-95) hard-exits with exit 1 whenever PR_NUMBER is empty on workflow_dispatch.

This was auto-filed and closed once already as #52987 (created 2026-08-15, closed 2026-08-16), but the closure did not land a fix β€” the same if [ "$EXPR_GITHUB_EVENT_NAME" = "workflow_dispatch" ] && [ -z "${PR_NUMBER:-}" ]; then exit 1; fi guard is still present verbatim in both the source .md and compiled .lock.yml today. This week's Agent Performance Report (discussion #53125) independently confirms the pattern: "One related fix attempt (#51422, 'Soften Design Decision Gate invocation-cap failures') was closed Aug 16 but failures continue post-close β€” the fix did not durably resolve the root cause," alongside 10+ recurring [aw] Design Decision Gate πŸ—οΈ failed auto-filed issues roughly every 1-2 days since Aug 8.

Note: this is a different root cause than the LLM-invocation-cap issue fixed by #52836 (merged 2026-08-15, which raised max-turns and added safe-output-aware cap suppression) β€” that fix is holding, but this codegen mismatch is a separate, still-open failure mode on the same workflow.

Expected Impact

Stops a merge-blocking gate workflow from spuriously failing (and re-auto-filing duplicate failure issues every 1-2 days) whenever it's invoked via bare workflow_dispatch without a pr_number input β€” either make the input genuinely optional (e.g. skip gracefully with a clear message) or make it required: true in the schema so the mismatch is caught at compile time instead of at runtime.

Suggested Agent

New Agent (compiler/workflow-frontmatter fix)

Estimated Effort

Quick (< 1 hour)

Data Source

DeepReport analysis, 2026-08-16 cycle β€” cross-verified via direct source read of design-decision-gate.md/.lock.yml plus discussion #53125 (Agent Performance Report) and closed issue #52987.

Generated by πŸ”¬ Deep Report Β· agent Β· 257.9 AIC Β· βŒ– 11 AIC Β· ⊞ 11.8K Β· β—·

  • expires on Aug 18, 2026, 10:35 AM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions