Skip to content

samples mode cannot replay call-workflow, dispatch-workflow, or replace-label #54811

Description

@dsyme

Summary

Three configured safe outputs cannot be exercised deterministically with --use-samples:

  • call-workflow compiles with a sample, but replay returns Tool not found: call_workflow.
  • dispatch-workflow compiles with a sample, but replay returns Tool not found: dispatch_workflow.
  • replace-label runs no engine and performs no output when no sample is present, but adding a sample is rejected at compile time: samples: no MCP tool schema found for "replace_label".

The handlers exist in actions/setup/js/safe_output_handler_manager.cjs, but sample validation/replay does not expose schemas/tools for them consistently.

Reproductions

Call workflow:

safe-outputs:
  call-workflow:
    workflows: [worker]
    samples:
      - workflow_name: worker
        inputs: { sentinel: sample }

Dispatch workflow:

safe-outputs:
  dispatch-workflow:
    workflows: [worker]
    samples:
      - workflow_name: worker
        inputs: { sentinel: sample }

Both compile, then fail in Replay safe-outputs samples (deterministic) with JSON-RPC -32601 Tool not found.

Replace label:

safe-outputs:
  replace-label:
    allowed-transitions:
      - from: old
        to: new
    samples:
      - item_number: "${{ github.event.issue.number }}"
        label_to_remove: old
        label_to_add: new

Compilation fails with:

samples: no MCP tool schema found for "replace_label" (yaml key "replace-label"). Available tools come from pkg/workflow/js/safe_outputs_tools.json

Expected behavior

Every safe output that supports workflow configuration should either support deterministic sample replay with a schema/tool, or fail configuration with a clear, consistent unsupported-samples diagnostic. call-workflow, dispatch-workflow, and replace-label should be replayable so suites using --use-samples do not silently skip the operation or fail at runtime.

E2E evidence

gh-aw ref: main at 1bdfdfa5a0f9; samples: true; AI engine not called.

No matching open issue was found using searches for apply_samples, the exact Tool not found messages, and the exact missing-schema diagnostic.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions