Skip to content

[plan] Fix MCPGatewayConfig naming collision #7370

Description

@github-actions

Objective

Resolve the critical type name collision where MCPGatewayConfig is defined with completely different structures in two locations.

Context

The same type name MCPGatewayConfig exists in:

  1. pkg/cli/mcp_gateway_command.go:24 - Container for multiple MCP servers
  2. pkg/workflow/tools_types.go:235 - Configuration for gateway execution

These represent fundamentally different concepts and need distinct names.

Approach

  1. Rename pkg/cli/mcp_gateway_command.go:24 type to MCPGatewayServersConfig
  2. Rename pkg/workflow/tools_types.go:235 type to MCPGatewayRuntimeConfig
  3. Update all references throughout the codebase:
    • Search for MCPGatewayConfig usage
    • Update to use the appropriate renamed type based on context
    • Update struct literal instantiations
  4. Run make test to verify no breakage

Files to Modify

  • pkg/cli/mcp_gateway_command.go - Rename type and update references
  • pkg/workflow/tools_types.go - Rename type and update references
  • Find and update all files referencing these types (use grep/ripgrep)

Acceptance Criteria

  • No type name collisions exist
  • Type names clearly indicate their purpose (servers vs runtime)
  • All references updated correctly
  • All tests pass (make test)
  • Build succeeds (make build)

Estimated Effort

2-3 hours
Related to #7369

AI generated by Plan Command for discussion #7368

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions