Skip to content

[plan] Fix SC2086: Add missing quotes in 5 workflows #7899

Description

@github-actions

Objective

Fix 10 occurrences of shellcheck SC2086 info-level issues across 5 workflows by adding proper quotes around variable references.

Problem

Unquoted variables can lead to unexpected word splitting or pathname expansion:

echo $variable        # ❌ Can split on whitespace, expand globs
command $arg         # ❌ May cause unexpected behavior

Solution

Add double quotes:

echo "$variable"     # ✅ Preserves spaces, prevents expansion
command "$arg"       # ✅ Treats as single argument

Why This Matters

  • Prevents word splitting on spaces/tabs/newlines
  • Prevents glob expansion (*, ?, etc.)
  • Ensures variables are treated as single arguments
  • Makes script behavior more predictable

Approach

  1. Search for unquoted variable usage: grep -n '\$[A-Za-z_]' .github/workflows/*.md
  2. Identify the 10 specific SC2086 violations from actionlint output
  3. Add quotes around each variable reference
  4. Recompile workflows: make recompile
  5. Verify with actionlint

Files to Modify

5 workflow .md files in .github/workflows/ (10 total occurrences)

Acceptance Criteria

AI generated by Plan Command for discussion #7889

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions